-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate AgentRunner to Agent Workflow (Python) #502
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c83fa96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
templates/types/streaming/fastapi/app/api/routers/vercel_response.py
Outdated
Show resolved
Hide resolved
templates/components/multiagent/python/app/api/routers/vercel_response.py
Outdated
Show resolved
Hide resolved
# TODO: Update non-streaming endpoint | ||
# Would be better if we use same chat.py endpoint for both agent and multiagent templates | ||
# # non-streaming endpoint - delete if not needed | ||
# @r.post("/request") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this endpoint is no longer usage (we just have a note for using it in the README.md file). I just updated to support the endpoint with the workflow - but adding support for source nodes would requires more handle logic so i removed the source nodes support here.
If we remove non-streaming endpoint, we don't need to override the chat.py
for the multiagent template (just need to resolve the import get_engine
problem then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
means we can remove the multiagent folder?
ecfd352
to
5a230be
Compare
b58913e
to
7e23d77
Compare
No description provided.