Create onMounting hook #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just have reviewed the PR. Currently it has conflicts. Could you clean it up and remove anything not related to the changed behavior itself? |
rumkin
requested changes
Sep 1, 2019
| onLoading(url) | ||
| } | ||
|
|
||
| function onClick (e) { | ||
| if (e.target.nodeName !== 'A') { | ||
| if (e.target.nodeName !== 'A' && !e.target.dataset.pillIgnore) { |
There was a problem hiding this comment.
Should be removed, it has already landed in another PR.
| @@ -162,6 +169,11 @@ will be served by browser. | |||
|
|
|||
| Determine wether previuosly loaded page should be loaded from server. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
It conflicts with already existing PR.
| "rollup": "^1.7.4", | ||
| "serve": "^10.1.2" | ||
| }, | ||
| "scripts": { | ||
| "start": "serve -l 8080 -n example", | ||
| "start": "npm run build && node copy-files.js && serve -l 8080 -n example", | ||
| "clean": "rm -rf dist", |
| @@ -0,0 +1,3 @@ | |||
| const copy = require('copy'); | |||
|
|
|||
| copy('dist/*.js', 'example', ()=> console.log('copied pill.js build into example')); | |||
There was a problem hiding this comment.
This part should be removed. It's presented in PR #10.
| <p> | ||
| <a name="anchor"></a> <span>Anchor</span> <a href="/pages/a">Page A</a> | ||
| </p> | ||
| </main> | ||
| </div> | ||
| <!-- PAGE CONTENT END --> | ||
| <script src='/site.js' type='module'></script> |
| </div> | ||
| <!-- PAGE CONTENT END --> | ||
| <script src='/site.js' type='module'></script> | ||
| </body> | ||
| </html> |
| </div> | ||
| <!-- PAGE CONTENT END --> | ||
| <script src='/site.js' type='module'></script> | ||
| </body> | ||
| </html> |
| @@ -1,4 +1,4 @@ | |||
| import pill from '/pill.js' | |||
|
|
|||
|
@rumkin Question: Should this be But I feel it should be |
|
@tamb Let's implement only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook fires before every content change. This way we can clean up any assets we may want to clean up before content changes.