Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chromium/Chrome support #127

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Added Chromium/Chrome support #127

merged 5 commits into from
Aug 5, 2022

Conversation

tdulcet
Copy link
Contributor

@tdulcet tdulcet commented Jun 6, 2022

Added initial Chromium/Chrome support. Fixes #54

Requires the downloading the webextension-polyfill to src/ and renaming the chromemanifest.json file to manifest.json and moving it to src/.

More extensive changes will be needed if/when #93 is merged.

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This looks simple enough, actually, I am somewhat surprised this is so easy. 🙃

src/common/modules/PageHandler.js Show resolved Hide resolved
src/popup/index.html Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tdulcet tdulcet mentioned this pull request Jun 13, 2022
rugk
rugk previously approved these changes Jun 14, 2022
@rugk
Copy link
Owner

rugk commented Jul 28, 2022

Well this is approved long ago. So I just press the merge button here…

Feel free to let me know if I overlook such things again and again. If it is approved, it's approved.🤷‍♂️

rugk and others added 2 commits July 30, 2022 00:25
Converted with Inkscape.

icon size of 128px choosen as per Chrome's guidelines:
https://developer.chrome.com/docs/webstore/images/#icons
@tdulcet tdulcet requested a review from rugk July 30, 2022 09:40
@rugk rugk merged commit 0f4e385 into rugk:main Aug 5, 2022
@rugk rugk deleted the chrome branch August 5, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome/ium support
2 participants