Skip to content

Commit

Permalink
avm2: Improve comment on avoiding caching for with-scopes
Browse files Browse the repository at this point in the history
  • Loading branch information
Lord-McSweeney authored and Lord-McSweeney committed Dec 14, 2024
1 parent a4652db commit a1c6b17
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion core/src/avm2/scope.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ impl<'gc> ScopeChain<'gc> {
// Wasn't in the objects traits, let's try dynamic properties if this is a with scope.
if scope.with() && values.has_own_property(multiname) {
// NOTE: We return the QName as `None` to indicate that we should never cache this result.
// We NEVER cache the result of dynamic properties.
// We NEVER cache the result of dynamic properties (and can't anyway because of the check
// in ScopeContainer::new).
return Ok(Some((None, values)));
}
}
Expand Down

0 comments on commit a1c6b17

Please sign in to comment.