Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sources to v2 batch1 #4085

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

vinayteki95
Copy link
Contributor

What are the changes introduced in this PR?

Modified below sources to accept and process v2 spec.

  • appcenter
  • appsflyer
  • auth0
  • braze
  • canny
  • close_crm
  • cordial
  • customerio

What is the related Linear task?

Resolves INT-3256

Please explain the objectives of your changes below

This is one set of sources that are migrated to v2 specification completely. This is part of the Webhook Sources Improvements project.

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

All the above sources process v2 specification instead of vo and v1.

Any new dependencies introduced with this change?

No

Any new generic utility introduced or modified. Please explain the changes.

message class utilised by all sources is replicated and placed in sources folder. This will be the norm for all sources with this project

Any technical or performance related pointers to consider with the change?

No

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@vinayteki95 vinayteki95 requested review from a team and sivashanmukh as code owners February 17, 2025 12:53
@vinayteki95 vinayteki95 changed the title Refactor.sources to v2 batch1 refactor: sources to v2 batch1 Feb 17, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 98.61111% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.11%. Comparing base (aed87ce) to head (b76c822).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/sources/message.js 95.34% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4085      +/-   ##
===========================================
- Coverage    91.13%   91.11%   -0.02%     
===========================================
  Files          629      631       +2     
  Lines        32840    32903      +63     
  Branches      7794     7799       +5     
===========================================
+ Hits         29928    29979      +51     
- Misses        2696     2706      +10     
- Partials       216      218       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip
Copy link
Contributor

Fix issues and code cov.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need duplicate of v0/sources/message.js till the entire migration ?

Copy link
Contributor Author

@vinayteki95 vinayteki95 Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the PRs are structured that way. In the last PR we will completely remove the old message.js.

This is mainly to limit the changes being done to a set of sources.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants