Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json marshal l errors when parsing poll response from klaviyo #5315

Closed
wants to merge 2 commits into from

Conversation

koladilip
Copy link
Contributor

@koladilip koladilip commented Nov 21, 2024

Description

There is a bug in the Klaviyo implementation where, at times, we receive an empty import ID from the upload. However, when we poll with an empty import ID, we encounter parsing errors because Klaviyo returns a list response when the import ID is empty.

Linear Ticket

https://linear.app/rudderstack/issue/INT-2820/klaviyo-bulk-upload-at-times-they-are-running-into-errors
Resolves INT-2820

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@koladilip koladilip force-pushed the fix/klaviyo-poll-json-marshall-issue branch from dbec53b to ce8df72 Compare November 21, 2024 07:47
@koladilip koladilip closed this Nov 21, 2024
@koladilip koladilip deleted the fix/klaviyo-poll-json-marshall-issue branch November 21, 2024 08:09
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.53%. Comparing base (f908e21) to head (85c1961).

Files with missing lines Patch % Lines
...destinationmanager/klaviyobulkupload/apiService.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5315      +/-   ##
==========================================
- Coverage   73.57%   73.53%   -0.04%     
==========================================
  Files         424      424              
  Lines       59935    59943       +8     
==========================================
- Hits        44095    44077      -18     
- Misses      13370    13402      +32     
+ Partials     2470     2464       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants