Chore.bol load r7 #5237
Chore.bol load r7 #5237
Conversation
…into chore.bol-load-r5
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| dbURL := fmt.Sprintf("postgres://postgres:%s@localhost:%d/testdb?sslmode=disable", randomPassword, freePort) | ||
|
|
||
| // Print the database URL | ||
| fmt.Printf("Database URL: %s\n", dbURL) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 26 days ago
To fix the problem, we should avoid logging the sensitive information contained in randomPassword. Instead of printing the entire dbURL, we can print a sanitized version that omits the password. This way, we maintain the functionality of logging the database URL without exposing sensitive information.
| @@ -146,5 +146,6 @@ | ||
| dbURL := fmt.Sprintf("postgres://postgres:%s@localhost:%d/testdb?sslmode=disable", randomPassword, freePort) | ||
| sanitizedDbURL := fmt.Sprintf("postgres://postgres:****@localhost:%d/testdb?sslmode=disable", freePort) | ||
|
|
||
| // Print the database URL | ||
| fmt.Printf("Database URL: %s\n", dbURL) | ||
| // Print the sanitized database URL | ||
| fmt.Printf("Database URL: %s\n", sanitizedDbURL) | ||
|
|
| fmt.Printf("\nFinal results:\n") | ||
| fmt.Printf("Processed %d events in %v\n", totalEvents, elapsed) | ||
| fmt.Printf("Average rate: %.2f events/second\n", float64(totalEvents)/elapsed.Seconds()) | ||
| fmt.Printf("Database URL: %s\n", dbURL) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Sidddddarth
force-pushed
the
chore.bol-load-r7
branch
from
5eda2db
to
9cb1ff2
Compare
… chore.bol-load-r7
| 0.5, 1, 2.5, 5, 10, 30, 60, 120, 180, 300, 600, 1800, 3600, 7200, 10800, 21600, 32400, 86400, // 0.5s, 1s, 2.5s, 5s, 10s, 30s, 1m, 2m, 3m, 5m, 10m, 30m, 1h, 2h, 3h, 6h, 9h, 24h | ||
| }, | ||
| "event_delivery_from_sent_time": { | ||
| 0.5, 1, 2.5, 5, 10, 30, 60, 120, 180, 300, 600, 1800, 3600, 7200, 10800, 21600, 32400, 86400, // 0.5s, 1s, 2.5s, 5s, 10s, 30s, 1m, 2m, 3m, 5m, 10m, 30m, 1h, 2h, 3h, 6h, 9h, 24h |
There was a problem hiding this comment.
do we need all these buckets? can we skip 2.5s, 2m, 3m, 2h as we might not need this much granular information.
| "module": "router", | ||
| "destType": w.rt.destType, | ||
| "destID": destination.ID, | ||
| "destination": destinationTag, |
There was a problem hiding this comment.
we can skip destination tag as it is combination of destinationID and destName. we already have destID
| "destination": destinationTag, | ||
| "workspaceId": status.WorkspaceId, | ||
| "sourceId": destinationJobMetadata.SourceID, | ||
| "sourceCategory": destinationJobMetadata.SourceCategory, |
There was a problem hiding this comment.
do we need source category as well here we already have sourceID
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Description
< Replace with adequate description for this PR as per Pull Request document >
Linear Ticket
< Replace with Linear Link ( create or search linear ticket) or >
Security