fix: refresh connections to avoid hotspotting of load distribution #5227
+60
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
reviewed
Oct 24, 2024
lvrach
reviewed
Oct 24, 2024
1 task
mihir20
reviewed
Nov 8, 2024
|
|
||
| if r.ttl > 0 && time.Since(r.lastRefreshTime) > r.ttl { | ||
| r.client.CloseIdleConnections() | ||
| r.client = r.clientFunc() |
There was a problem hiding this comment.
what if 1 goroutine comes and gets a http client and make a http-request and while that request is in flight another go routine comes and ttl is passed we closed all the ideal conns(conn made by the 1st goroutine is still not closed as the req is in flight) and recycle the http client. But since first req is already in flight can this cause some resource to leak?
There was a problem hiding this comment.
Thats true. We should combine this with: IdleConnTimeout (can be equal to r.lastRefreshTime) Eventually resources would freed up.
lvrach
requested changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed uneven load distribution to upstream transformation services due to long lived connections. So recycling client to force refresh of connections to transformer.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1669/refresh-transformer-connections-periodically-on-client-side
Security