fixup! chore: emit metrics using transformer response headers. TODO: …

…cleanup
rudderlabs · Feb 3, 2025 · 8734959 · 8734959
1 parent 628b601
commit 8734959
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/internal/transformer-client/client.go b/internal/transformer-client/client.go
@@ -2,6 +2,8 @@ package transformerclient
 
 import (
 	"context"
+	"github.com/bufbuild/httplb/resolver"
+	"net"
 	"net/http"
 	"time"
 
@@ -91,8 +93,9 @@ func NewClient(config *ClientConfig) Client {
 			httplb.WithHealthChecks(getChecker(checkerType, config.CheckURL)),
 			httplb.WithIdleConnectionTimeout(transport.IdleConnTimeout),
 			httplb.WithRequestTimeout(client.Timeout),
-			httplb.WithRoundTripperMaxLifetime(clientTTL),
-			httplb.WithIdleTransportTimeout(2*clientTTL),
+			httplb.WithRoundTripperMaxLifetime(transport.IdleConnTimeout),
+			httplb.WithIdleTransportTimeout(2*transport.IdleConnTimeout),
+			httplb.WithResolver(resolver.NewDNSResolver(net.DefaultResolver, resolver.PreferIPv4, clientTTL),
 		)
 	default:
 		return client

diff --git a/processor/transformer/transformer.go b/processor/transformer/transformer.go
@@ -241,8 +241,8 @@ func NewTransformer(conf *config.Config, log logger.Logger, stat stats.Stats, op
 		PickerType:    conf.GetString("Transformer.Client.httplb.pickerType", "power_of_two"),
 		CheckerType:   conf.GetString("Transformer.Client.httplb.checkerType", "nop"),
 
-		// for now no health checks - can be implemented when there are different clients for UT, DT, TPV
-		// CheckURL: trans.config.userTransformationURL,
+		//for now no health checks - can be implemented when there are different clients for UT, DT, TPV
+		CheckURL: trans.config.userTransformationURL,
 	}
 	transformerClientConfig.TransportConfig.DisableKeepAlives = trans.config.disableKeepAlives
 	transformerClientConfig.TransportConfig.MaxConnsPerHost = trans.config.maxHTTPConnections
@@ -508,7 +508,6 @@ func (trans *handle) doPost(ctx context.Context, rawJSON []byte, url, stage stri
 				req.Header.Set("X-Feature-Filter-Code", "?1")
 
 				resp, reqErr = trans.httpClient.Do(req)
-
 			})
 			trans.stat.NewTaggedStat("processor.transformer_request_time", stats.TimerType, tags).SendTiming(time.Since(requestStartTime))
 			if reqErr != nil {