Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a call to nil on objects to destroy #475

Open
wants to merge 4 commits into
base: core
Choose a base branch
from

Conversation

Shigawire
Copy link

When a model has no :dependent option in their association, this is nil. target.send(options[:dependent]) will fail in this case.

When a model has no :dependent option in their association, this is nil. `target.send(options[:dependent])` will fail in this case.
@Shigawire Shigawire changed the title Fixes a call to nil on objects to destroy Fix a call to nil on objects to destroy Jul 9, 2019
Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case to reproduce the problem this fixes ?

thanks

@mathieujobin
Copy link
Collaborator

revisiting this... I really would like to see a test that reproduce the problem without the patch...

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants