Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dirty tracking #416

Open
wants to merge 3 commits into
base: core
Choose a base branch
from
Open

Feature/dirty tracking #416

wants to merge 3 commits into from

Conversation

dgmora
Copy link

@dgmora dgmora commented Aug 8, 2017

I took what the first commit from #375

As far as I understood, update_columns does not track changes with Dirty because it does not use the regular attribute setters, it uses raw_write_attribute. raw_write_attribute also clears the changes in 5.1.x. See here (which is called from update_columns. super is in persistence).

Adding deleted_at_will_change! and changes_applied works except for rails 5.0.x, couldn't find the reason. It looks like the AttributeMutationTracker does not track the change in deleted_at correctly

@mathieujobin
Copy link
Collaborator

can you rebase or merge core into your branch ?

Copy link
Collaborator

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants