Combined/deleted duplicate httparty gem advisory as part of PR#585 #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postmodern
requested changes
Nov 12, 2025
Member
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Noticed two things that were added, but otherwise approve of the deletion.
| - https://github.com/jnunemaker/httparty/security/advisories/GHSA-5pq7-52mg-hr42 | ||
| - https://github.com/jnunemaker/httparty/commit/cdb45a678c43e44570b4e73f84b1abeb5ec22b8e | ||
| - https://github.com/jnunemaker/httparty/blob/4416141d37fd71bdba4f37589ec265f55aa446ce/lib/httparty/request/body.rb#L43 | ||
| - https://bugzilla.mozilla.org/show_bug.cgi?id=1556711 |
Member
There was a problem hiding this comment.
How is this link related to httparty? Seems to relate more to Firefox, but does mention Ruby on Rails.
| * An attack that rewrites the \"name\" field according to the | ||
| crafted file name, impersonating (overwriting) another field. | ||
| * Attacks that rewrite the filename extension at the time | ||
| multipart/form-datais generated by tampering with the filename. |
Member
There was a problem hiding this comment.
Do we really need a separate section for the GHSA version of the description? Might be better to merge the information into the above description text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined/deleted duplicate httparty gem advisory as part of PR#585
In connection with PR#585, merged GHSA-5pq7-52mg-hr42.yml into CVE-2024-22049.yml
then deleted GHSA-5pq7-52mg-hr42.yml as duplicate.