-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed 3 lines in lib/github_advisory_sync.rb script to get rid of unneeded debug text #637
Conversation
The debug lines should stay, as they instruct the user to replace |
I duplicated those lines in #570 so this whole section could be ignored during my daily runs. |
I ended up replacing |
How about this compromise? "patched_versions" => ['FIX ME', vulnerabilities], |
I would prefer to either try to parse the |
I wonder if we could derive |
I looking forward to seeing how you solve "derive the patched_versions and unaffected_versions fields" issue. |
@jasnow random question, is |
I do not know. I never focus of what GHSA format said, just what I need to convert to your format. Here is one example:
Converts to (omit unaffected_versions: field):
|
Removed 3 lines in lib/github_advisory_sync.rb script to get rid of unneeded debug text.
This change is needed as part of #537.
The 3 lines are:
Here is a sample of the above script lines:
@reedloden