This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
Standardize errors #112
Merged
Standardize errors #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevecheckoway
force-pushed
the
standardize-errors
branch
from
3f57913
to
e844f21
Compare
All of the standard tokenizer errors are implemented with their given error code strings. Each transition of the tokenizer state machine that emit one or more errors is tested to emit exactly those errors and no others. Those transitions that do not emit an error are tested to ensure that they do not. The `GumboError` is opaque to callers and the `GumboStringBuffer` is not exposed. The error codes of the defined errors as well as the two encoding errors and a generic parser error are available via `gumbo_error_code`. In Nokogiri, the error code is exposed via `Nokogiri::XML::SyntaxError#str1`.
stevecheckoway
force-pushed
the
standardize-errors
branch
from
e844f21
to
f82f32f
Compare
Replace
```
if (foo) {
return x();
} else if (bar) {
return y();
} else {
return z();
}
```
with
```
if (foo) {
return x();
}
if (bar) {
return y();
}
return z();
```
|
I've now gone through the parser pretty carefully and tried to fix everything but it needs tests. Separately, I was hoping to turn on errors for the html5lib tests but those tests are missing a bunch of errors or have the wrong errors (e.g., html5lib/html5lib-tests#108, html5lib/html5lib-tests#109, html5lib/html5lib-tests#110, html5lib/html5lib-tests#111, and html5lib/html5lib-tests#112). Once those are resolved, there are still about 100 test cases that fail due to errors, either in the tests or in gumbo. |
The parser now implements the updated tree-construction stage including producing the same number of errors specified in the html5lib-tests tree-construction tests (at least it will after the tests are fixed as per https://github.com/html5lib/html5lib-tests/compare/master...stevecheckoway:all-error-fixes?expand=1).
stevecheckoway
force-pushed
the
standardize-errors
branch
from
1439477
to
730497f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the standard tokenizer errors are implemented with their given
error code strings.
Each transition of the tokenizer state machine that emit one or more
errors is tested to emit exactly those errors and no others. Those
transitions that do not emit an error are tested to ensure that they do
not.
The
GumboErroris opaque to callers and theGumboStringBufferis notexposed. The error codes of the defined errors as well as the two
encoding errors and a generic parser error are available via
gumbo_error_code.In Nokogiri, the error code is exposed via
Nokogiri::XML::SyntaxError#str1.