Add bulk assignment of volunteers to supervisor #5144

jamgar · 2023-08-22T22:26:10Z

styling and controller updates
Add request test for bulk assignment
add datatable checkboxes to volunteer#index view for bulk assignment update styles for volunteer#index table

What github issue is this PR for, if any?

Resolves #2523

What changed, and why?

Added multi select checkboxes to Volunteers#index

How will this affect user permissions?

Volunteer permissions: N/A
Supervisor permissions: N/A
Admin permissions: N/a

How is this tested? (please write tests!) 💖💪

Created request specs for the bulk assign and unassign

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

MalloryPriceDesign · 2023-08-25T21:14:31Z

@jamgar Thank you for your work on this—it looks fantastic! I'm really looking forward to seeing it in action. I just have a small request: could you please update the text in the modal to match the following:

Choose a new supervisor from the dropdown below to reassign selected volunteers, or select “No Supervisor” to unassign volunteers. When you're ready, go ahead and click the "Confirm" button to apply the changes.

Thank you so much for your help!

FireLemons · 2023-08-26T20:51:15Z

can you make your docker and rspec checks pass?

jamgar · 2023-08-31T23:43:39Z

@FireLemons I can take another look, but the rspec were failing in main as I tested in that branch to compare.

littleforest · 2023-09-01T03:15:45Z

@jamgar could you merge or rebase in the main branch?

jamgar · 2023-09-01T20:15:45Z

I think I found the issue with the test 😊 I am fixing now and will rebase.

FireLemons · 2023-09-09T20:35:54Z

I'm getting z fighting for the dropdown. I have up to date yarn dependencies and up to date compiled assets.

FireLemons · 2023-09-10T04:00:46Z

I tried again on a chromium browser(earlier test was on firefox) on a different computer. Got the same result

bcastillo32 · 2023-09-25T19:42:45Z

@FireLemons can we merge this yet or no? :) @jamgar anything you need help with?

jamgar · 2023-10-13T14:39:45Z

I'm getting z fighting for the dropdown. I have up to date yarn dependencies and up to date compiled assets.

It seems the issue is with the Jquery Select2. If I remove the class 'select2' it goes back to the default select box and shows correct.

FireLemons · 2023-10-14T18:42:13Z

It still looks the same on my machine after a database reset and fresh asset build. I'll try again on a different computer in a while

FireLemons · 2023-10-14T18:44:16Z

Could you write a system test for this feature? It will simulate a user using the website and might help you verify your feature.

jamgar · 2023-10-16T20:06:46Z

It still looks the same on my machine after a database reset and fresh asset build. I'll try again on a different computer in a while

Can you check that 'select2' class is missing from the volunteers.html.erb file in your branch? That was what was causing the zindex issue. After removing the select2 it reverted to the default dropdown and worked

I will see about writing a system test.

Co-authored-by: James Garcia <[email protected]> add datatable checkboxes to volunteer#index view for bulk assignment add system test for volunteers/index

schoork · 2024-01-13T13:37:17Z

spec/requests/supervisor_volunteers_spec.rb

+      it "sets that association to active" do
+        valid_parameters = {
+          supervisor_volunteer: {supervisor_id: supervisor.id, volunteer_ids: [volunteer_1.id, volunteer_2.id, volunteer_3.id]}
+        }
+        sign_in(admin)
+
+        expect {
+          post bulk_assignment_supervisor_volunteers_url, params: valid_parameters, headers: {HTTP_REFERER: supervisors_path.to_s}
+        }.to change(SupervisorVolunteer, :count).by(2) # bc 1 already exists, we are creating 2 new ones
+        expect(response).to redirect_to volunteers_path
+
+        association.reload
+        expect(association.is_active?).to be(true)


This looks like 2 tests. Generally we'd split into 2.

Expect to add for new ones

Expect to make active for inactive ones

major redesign

response to test issues and code climate

schoork · 2024-01-31T21:47:49Z

@compwron Can I get your eyes on this review? It's just a code climate issue failing.

compwron · 2024-02-01T01:35:35Z

 Failed examples:

rspec ./spec/models/casa_org_spec.rb:97 # CasaOrg generate_contact_types_and_hearing_types generates default contact type groups matches default contact type groups
rspec ./spec/system/volunteers/index_spec.rb:213 # view all volunteers admin user Manage Volunteers button when one or more volunteers selected text matches pluralization of volunteers selected
rspec ./spec/system/volunteers/index_spec.rb:205 # view all volunteers admin user Manage Volunteers button when one or more volunteers selected displays number of volunteers selected

Failed examples:

rspec ./spec/system/volunteers/index_spec.rb:205 # view all volunteers admin user Manage Volunteers button when one or more volunteers selected displays number of volunteers selected
rspec ./spec/policies/supervisor_policy_spec.rb:55 # SupervisorPolicy update? does not allow supervisors to update other supervisors

Randomized with seed 15807

Run yarn lint
yarn run v1.22.21
$ standard
standard: Use JavaScript Standard Style (https://standardjs.com/)
standard: Run `standard --fix` to automatically fix some problems.
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:5:29: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:7:29: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:8:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:10:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:10:32: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:11:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:13:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:13:35: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:14:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:16:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:16:31: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:17:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:19:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:19:42: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:20:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:22:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:22:29: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:23:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:25:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:25:34: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:26:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:28:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:28:38: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:29:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:31:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:31:30: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:32:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:34:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:34:33: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:35:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:37:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:37:31: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:38:22: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:40:1: Import in body of module; reorder to top. (import/first)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:40:36: Strings must use singlequote. (quotes)
  /home/runner/work/casa/casa/app/javascript/controllers/index.js:41:22: Strings must use singlequote. (quotes)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
Error: Process completed with exit code 1.

compwron · 2024-02-01T01:36:22Z

spec/system/volunteers/index_spec.rb

@@ -318,17 +480,5 @@
        expect(input_search.value).to eq("")
      end
    end
-
-    context "when timed out" do


Do not delete this test.

compwron · 2024-02-01T01:37:16Z

It looks like it's getting very close! some yarn lint, and maybe some test failures? They miiight be flakes, but I'm not sure.

bcastillo32 · 2024-02-11T00:15:18Z

It looks like it's getting very close! some yarn lint, and maybe some test failures? They miiight be flakes, but I'm not sure.

@schoork can you make some magic happen so we can get this merged? 😎

schoork · 2024-02-11T12:57:27Z

app/models/user.rb

@@ -119,7 +119,7 @@ def no_attempt_for_two_weeks
      if volunteer.supervisor.active? &&
          volunteer.case_assignments.any? { |assignment| assignment.active? } &&
          (volunteer.case_contacts.none? ||
-          volunteer.case_contacts.maximum(:occurred_at) < (Time.zone.now - 14.days))


Since occurred_at is not required for a draft, if a user has only drafts with occurred_at set to nil, this creates a NoMethodError.

schoork · 2024-02-11T12:59:43Z

It looks like it's getting very close! some yarn lint, and maybe some test failures? They miiight be flakes, but I'm not sure.

Ugh... before in a parent describe works before let in a child context so was visiting the volunteers_page before the volunteers existed.

schoork · 2024-02-11T19:03:42Z

It looks like it's getting very close! some yarn lint, and maybe some test failures? They miiight be flakes, but I'm not sure.

@schoork can you make some magic happen so we can get this merged? 😎

Thanks for the push @bcastillo32

bcastillo32 · 2024-02-21T22:02:05Z

@FireLemons @littleforest or @compwron - is this good to go for this week's release? :)

compwron · 2024-02-25T18:49:21Z

spec/system/volunteers/index_spec.rb

@@ -263,6 +263,7 @@
          end

          find("[data-select-all-target='checkboxAll']").click
+          sleep(1)


this is not a good fix and makes tests slow. Let's TODO remove this. @bcastillo32 can you open a ticket to clean this up?

compwron · 2024-02-25T18:49:59Z

yarn.lock

@@ -3994,7 +3994,7 @@ joi@^17.11.0:
    "@sideway/formula" "^3.0.1"
    "@sideway/pinpoint" "^2.0.0"

-jquery@>=1.7, "jquery@>=3.4.0 <4.0.0", jquery@^3.6.4:
+jquery@>=1.7, "jquery@>=3.4.0 <4.0.0", jquery@^3.7.1:


nice to upgrade :)

compwron

let's merge! this will be great to get into prod :)

jamgar requested review from compwron, FireLemons and littleforest as code owners August 22, 2023 22:26

github-actions bot added dependencies Pull requests that update a dependency file javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏 erb labels Aug 22, 2023

jamgar force-pushed the st-eh/2523/AssignMultipleVolunteersAtOnce branch from 0d72870 to 123423d Compare August 25, 2023 02:13

jamgar mentioned this pull request Aug 25, 2023

Add a Way to Assign Multiple Volunteers at Once #2523

Closed

jamgar force-pushed the st-eh/2523/AssignMultipleVolunteersAtOnce branch 3 times, most recently from 4b37087 to 1ec68e1 Compare September 2, 2023 13:58

jamgar force-pushed the st-eh/2523/AssignMultipleVolunteersAtOnce branch from c0c47f1 to 8e68617 Compare October 13, 2023 15:17

github-actions bot added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Oct 13, 2023

Co-authored-by: Eric Halverson <[email protected]>

9f6b4b3

Co-authored-by: James Garcia <[email protected]> add datatable checkboxes to volunteer#index view for bulk assignment add system test for volunteers/index

jamgar force-pushed the st-eh/2523/AssignMultipleVolunteersAtOnce branch from 6078721 to 9f6b4b3 Compare October 17, 2023 15:27

schoork reviewed Jan 13, 2024

View reviewed changes

Sam Williams added 5 commits January 13, 2024 13:13

Assign Multiple Volunteers //

409aedc

major redesign

AssignMultipleVolunteersAtOnce //

f15d1ec

response to test issues and code climate

test fixes

cb7d40e

test fixes

a473606

test fixes

cb4107c

Merge branch 'main' into st-eh/2523/AssignMultipleVolunteersAtOnce

e56e198

compwron reviewed Feb 1, 2024

View reviewed changes

Lint fix

6f728d5

fixes for tests

420efb1

schoork reviewed Feb 11, 2024

View reviewed changes

Sam Williams added 6 commits February 11, 2024 08:21

Test fixes

1855f40

Test fixes

e97f93e

Test fixes

299a9d3

Test fixes

a41d310

Test fixes

25e7609

Test fixes

cd3d92d

compwron reviewed Feb 25, 2024

View reviewed changes

compwron approved these changes Feb 25, 2024

View reviewed changes

compwron merged commit 8928bf1 into main Feb 25, 2024
14 of 15 checks passed

compwron deleted the st-eh/2523/AssignMultipleVolunteersAtOnce branch February 25, 2024 18:51

compwron mentioned this pull request Feb 26, 2024

refactor test to not need sleep #5548

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add bulk assignment of volunteers to supervisor #5144

Add bulk assignment of volunteers to supervisor #5144

jamgar commented Aug 22, 2023 •

edited by elasticspoon

Loading

MalloryPriceDesign commented Aug 25, 2023

FireLemons commented Aug 26, 2023

jamgar commented Aug 31, 2023

littleforest commented Sep 1, 2023

jamgar commented Sep 1, 2023

FireLemons commented Sep 9, 2023

FireLemons commented Sep 10, 2023

bcastillo32 commented Sep 25, 2023

jamgar commented Oct 13, 2023

FireLemons commented Oct 14, 2023 •

edited

Loading

FireLemons commented Oct 14, 2023 •

edited

Loading

jamgar commented Oct 16, 2023

schoork Jan 13, 2024

schoork commented Jan 31, 2024

compwron commented Feb 1, 2024

compwron Feb 1, 2024

compwron commented Feb 1, 2024

bcastillo32 commented Feb 11, 2024

schoork Feb 11, 2024

schoork commented Feb 11, 2024

schoork commented Feb 11, 2024

bcastillo32 commented Feb 21, 2024

compwron Feb 25, 2024

compwron Feb 25, 2024

compwron left a comment

Add bulk assignment of volunteers to supervisor #5144

Add bulk assignment of volunteers to supervisor #5144

Conversation

jamgar commented Aug 22, 2023 • edited by elasticspoon Loading

What github issue is this PR for, if any?

What changed, and why?

How will this affect user permissions?

How is this tested? (please write tests!) 💖💪

Screenshots please :)

Feelings gif (optional)

Feedback please? (optional)

MalloryPriceDesign commented Aug 25, 2023

FireLemons commented Aug 26, 2023

jamgar commented Aug 31, 2023

littleforest commented Sep 1, 2023

jamgar commented Sep 1, 2023

FireLemons commented Sep 9, 2023

FireLemons commented Sep 10, 2023

bcastillo32 commented Sep 25, 2023

jamgar commented Oct 13, 2023

FireLemons commented Oct 14, 2023 • edited Loading

FireLemons commented Oct 14, 2023 • edited Loading

jamgar commented Oct 16, 2023

schoork Jan 13, 2024

Choose a reason for hiding this comment

schoork commented Jan 31, 2024

compwron commented Feb 1, 2024

compwron Feb 1, 2024

Choose a reason for hiding this comment

compwron commented Feb 1, 2024

bcastillo32 commented Feb 11, 2024

schoork Feb 11, 2024

Choose a reason for hiding this comment

schoork commented Feb 11, 2024

schoork commented Feb 11, 2024

bcastillo32 commented Feb 21, 2024

compwron Feb 25, 2024

Choose a reason for hiding this comment

compwron Feb 25, 2024

Choose a reason for hiding this comment

compwron left a comment

Choose a reason for hiding this comment

jamgar commented Aug 22, 2023 •

edited by elasticspoon

Loading

FireLemons commented Oct 14, 2023 •

edited

Loading

FireLemons commented Oct 14, 2023 •

edited

Loading