Add Berlin Buzzwords and FOSS Backstage#170
Add Berlin Buzzwords and FOSS Backstage#170tthePB wants to merge 137 commits intorubyberlin:mainfrom
Conversation
Add Berlin Node.js Community Meetup
Add Berlin.JS to Berlin Code Of Conduct
Added macoun.de to the list of conferences
Add Rustfest.eu
Hamburg React Meetup
add decodehh contacts
add DO!Hack Hackathon 2016
Italian translation
Add Berlin C++ User Group
Update supporters.json
I just noticed that titles are all caps, so I did spacing in the names of our projects:)
Update supporters.json
Add serverless Hamburg Usergroup
Added C++ User Group Munich
add BeeScalaConf
Add contacts to React Day Berlin section
feat(add meetup): add SinnerSchrader Hamburg meetup
Add PyLight Meetup to supporters.json
…mmons-license-link Added link to Creative commons license reference in spanish version
Add RubyUnconf Hamburg
Update supporters.json
Add the Malmö.rb user group as Supporters
| { | ||
| "name": "Ekaterina Klykova", | ||
| "email": "ekl@newthinking.de" | ||
| "phone": "+493092105978" |
There was a problem hiding this comment.
There are several parsing errors in the JSON files. You can see the red markers here on Github. Please fix first. Thanks :)
| { | ||
| "name": "Paul Berschick", | ||
| "email": "pbe@newthinking.de" | ||
| "phone": "+493092105977" |
There was a problem hiding this comment.
Also please use one space after the colon for the beauty of it :)
| "phone": "+493092105977" | ||
| }, | ||
| ] | ||
| }, |
There was a problem hiding this comment.
JSON does not allow a comma here (and other places).
error corrections
|
Made all changes – hope everything works now. I'm something of a beginner, so thanks for the feedback, @hagenburger :) |
hagenburger
left a comment
hagenburger
left a comment
There was a problem hiding this comment.
Hey @tthePB, we’re open for beginners and invite everybody to contribute and learn :) I added some more comments, please have a look.
Before you submit, you could check the syntax in the Terminal by parsing it either with Node:
node -e "const fs = require('fs'); console.log(JSON.parse(fs.readFileSync('data/supporters.json')))"
or with Ruby:
ruby -e "require 'json'; puts JSON.parse(File.read('data/supporters.json'))"
Both will either output the JSON (but compressed) or raise an error.
| "email": "ekl@newthinking.de", | ||
| "phone": "+49 3092105978" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Please align the curly braces below each other for the beauty of it:
},
{
| "name": "Paul Berschick", | ||
| "email": "pbe@newthinking.de", | ||
| "phone": "+49 3092105977" | ||
| }, |
There was a problem hiding this comment.
Only add a comma, when another opening { is following. The last item in JSON must not have a comma (in JavaScript this would be allowed though).
| "name": "Paul Berschick", | ||
| "email": "pbe@newthinking.de", | ||
| "phone": "+49 3092105977" | ||
| }, |
| "email": "ekl@newthinking.de", | ||
| "phone": "+49 3092105978" | ||
| }, | ||
| { |
| }, | ||
| ] | ||
| }, | ||
| { |
|
Hey @tthePB, is there anything I can do for you with this pull request? Let me know if you have any questions! |
|
Thanks @hagenburger, I just had no capacity in the last weeks. Will have a look at the comments you gave soon :) |
|
Hey, thanks so much and thanks for your patience! Due to the JSON nature of the file I had to rebase it by hand and couldn’t update this PR, but I merged it to |
20 participants
No description provided.