Support rest arguments #284
Conversation
alpaca-tc
force-pushed
the
support-splat-array
branch
2 times, most recently
from
bdafbc1 to
c9511a4
Compare
| @f_args.rest_positionals.each_type do |ty| | ||
| if ty.is_a?(Type::Instance) && ty.mod == genv.mod_ary && ty.args[0] |
There was a problem hiding this comment.
I noticed some duplicate code, which feels a bit dirty, but I decided to go ahead and open the PR since cleaning it up won't matter if the approach itself is flawed.
Do you have any suggestions for making this part of the code more DRY? The simplest solution would be to define a private method to consolidate the logic, but it doesn't feel like the optimal approach...
- Initialized rest arguments in method definitions as array. - Updated method call to add edges to array types. Further improvements may be possible.
mame
force-pushed
the
support-splat-array
branch
from
c9511a4 to
588aec8
Compare
|
Thank you! It looks good to me. TBH, I am not sure if this design has any flaw or not. We can reconsider it if we actually use it and find any problem. As for DRY, I have no strong opinion, but I think this PR is acceptable. The TypeProf source code is very difficult to understand, I guess it may be easier to understand if it is written plainly, even if it is a bit duplicated. |
Further improvements may be possible.