Skip to content

Improve specs for Array#fetch_values #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrykonchin merged 2 commits into from
May 29, 2025
Merged

Improve specs for Array#fetch_values #1267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8b950c
Add exception messages to specs of Array#fetch_values
herwinw May 28, 2025
8099660
Add explicit spec for Array#fetch_values with Range argument
herwinw May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions core/array/fetch_values_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

describe "with unmatched indexes" do
it "raises a index error if no block is provided" do
-> { @array.fetch_values(0, 1, 44) }.should raise_error(IndexError)
-> { @array.fetch_values(0, 1, 44) }.should raise_error(IndexError, "index 44 outside of array bounds: -3...3")
end

it "returns the default value from block" do
Expand All @@ -42,8 +42,14 @@
@array.fetch_values(obj).should == [:c]
end

it "does not support a Range object as argument" do
-> {
@array.fetch_values(1..2)
}.should raise_error(TypeError, "no implicit conversion of Range into Integer")
end

it "raises a TypeError when the passed argument can't be coerced to Integer" do
-> { [].fetch_values("cat") }.should raise_error(TypeError)
-> { [].fetch_values("cat") }.should raise_error(TypeError, "no implicit conversion of String into Integer")
end
end
end