-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bundle install --target-rbconfig
to install gems for Wasm target
#490
Open
kateinoigakukun
wants to merge
11
commits into
main
Choose a base branch
from
katei/bundle-install-target-rbconfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+216
−58
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 89fc464 - Browse repository at this point
Copy the full SHA 89fc464View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a5ed12 - Browse repository at this point
Copy the full SHA 5a5ed12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 483ae14 - Browse repository at this point
Copy the full SHA 483ae14View commit details -
Upload artifact before running tests
This helps investigate test failures
Configuration menu - View commit details
-
Copy full SHA for 3f905d5 - Browse repository at this point
Copy the full SHA 3f905d5View commit details -
Make
--enable-component-model
the default forjs
gemIn this way, we can avoid the need to specify `BUNDLE_BUILD__JS=--enable-component-model` when running `bundle install` for the `js` gem. When running `bundle install`, it's usually dynamic-linking enabled, so it makes sense to enable the component model by default.
Configuration menu - View commit details
-
Copy full SHA for 232b8dc - Browse repository at this point
Copy the full SHA 232b8dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 76bd2c4 - Browse repository at this point
Copy the full SHA 76bd2c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fca025 - Browse repository at this point
Copy the full SHA 3fca025View commit details -
Fix bin/setup not to install ruby-head-wasm-wasi's Gemfile
The ruby-head-wasm-wasi's Gemfile uses vendor/cache to install js gem but the cache gem is not yet available at setup-time. And also with cache gem, the Gemfile is not needed to be installed at setup-time. So just skip the Gemfile installation here
Configuration menu - View commit details
-
Copy full SHA for 6703565 - Browse repository at this point
Copy the full SHA 6703565View commit details -
Configuration menu - View commit details
-
Copy full SHA for d787c23 - Browse repository at this point
Copy the full SHA d787c23View commit details
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 54742bc - Browse repository at this point
Copy the full SHA 54742bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b66668 - Browse repository at this point
Copy the full SHA 0b66668View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.