Skip to content

Conversation

sampersand
Copy link
Contributor

@sampersand sampersand commented Oct 7, 2025

This PR updates nearly all usages of string | _ToPath to just path, which are functionally identical.

Of note:

  • Most of the changes are string | _ToPath, but a few of them were String | _ToPath. While this is functionally different, (path implies _ToStr), I verified that all the changed String | _ToPath do actually accept _ToStrs.
  • FileUtils::path is now just an alias for the top-level ::path and is marked as deprecated.
  • Find.find accepts String | _ToPath, but it's not quite right because Find.find also needs .dup, and some other things. Since I wanted this to be a simple PR, I didn't touch Find.find

Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ksss ksss added this pull request to the merge queue Oct 12, 2025
Merged via the queue into ruby:master with commit aed019e Oct 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants