Migrate usages of ::_ToPath to use ::path instead #2677
Merged
+69
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates nearly all usages of
string | _ToPath
to justpath
, which are functionally identical.Of note:
string | _ToPath
, but a few of them wereString | _ToPath
. While this is functionally different, (path
implies_ToStr
), I verified that all the changedString | _ToPath
do actually accept_ToStr
s.FileUtils::path
is now just an alias for the top-level::path
and is marked as deprecated.Find.find
acceptsString | _ToPath
, but it's not quite right becauseFind.find
also needs.dup
, and some other things. Since I wanted this to be a simple PR, I didn't touchFind.find