pkcs7: fix test failure on RHEL 9 #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using test_pkcs7.rb as an example invalid input is not reliable because we may happen to include a valid PKCS#7 PEM block in a heredoc.
The test case test_split_content fails on RHEL 9 and Fedora 41 because their OpenSSL packages do not accept SHA-1 signatures. This was only caught after commit 69fd7f8 added the missing assertion. While the example PKCS#7 structures could be simply regenerated with SHA-256, this test case could be simplified because it is checking two different things. Replace test_split_content with separate test cases: one verifying signed-data authenticatedAttributes and another for decoding BER input. Fixes ruby#875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case
test_split_contentfails on RHEL 9 and Fedora 41 because their OpenSSL packages do not accept SHA-1 signatures. This was only caught after commit 69fd7f8 added the missing assertion.While the example PKCS#7 structures could be simply regenerated with SHA-256, this test case could be simplified because it is checking two different things.
Replace
test_split_contentwith separate test cases: one verifyingsigned-dataauthenticatedAttributesand another for decoding BER input.Fixes #875