Refactor ndloop.c #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract some function from ndloop_alloc
Extract the following functions from ndloop_alloc: * ndloop_setup_lp_trans_map * ndloop_setup_lp_reduce * ndloop_set_trans_map_identity * check_args_length
Extract the following functions from ndloop_init_args. * ndloop_lp_has_an_empty_element * ndloop_xarg_readwrite_flag * ndloop_init_arg_by_narray
Extract get_pointer_for_rwflag from ndloop_set_stepidx.
refactroing ndloop_run
Extract the following functions from ndloop_init_args * ndloop_set_noloop * ndloop_init_arg_by_array * ndloop_reject_no_data_array * ndloop_set_step_for_linear_data * ndloop_set_stepidx_for_view
New function: ndloop_max_nd
Modify ndloop_set_step_for_linear_data nhand ndloop_set_stepidx_for_view.
Refactor ndloop_set_output. Extract ndloop_set_output_rarray function from ndloop_set_output.
Refactor ndloop_get_arg_type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactoring of ndoop.c.