Fix CI failures and improve Ruby 3.3 support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix following warning message in CI: ``` Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. ``` Because the CI will eventually stop working.
It installs bundler without specifying the version in CI. But, it installs bundler which does not work with old Ruby, and it causes failure. So, this patch remove bundler installation and uses bundler bundled in Ruby.
The method of getting pointers from TypedData structure has changed since Ruby 3.3. Ruby 3.2 or below can get the pointer with DATA_PTR(). https://github.com/ruby/ruby/blob/52bb2ac0a6971d0391efa2275f7a66bff319087c/error.c#L1073 Ruby 3.3 or later uses RTYPEDDATA_GET_DATA() to get pointer. https://github.com/ruby/ruby/blob/5124f9ac7513eb590c37717337c430cb93caa151/error.c#L1326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix CI failures and improve Ruby 3.3 support.