Skip to content

Small refactor versioner middlewares #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericproulx
Copy link
Contributor

This PR applies a small refactor to Grape::Middleware::Versioner::Base.

  • Defines method dynamically
  • Evaluate error_headers when initializing
  • Simplify potential version check.

@ericproulx ericproulx requested a review from dblock July 13, 2025 14:47
@grape-bot
Copy link

grape-bot commented Jul 13, 2025

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@ericproulx ericproulx force-pushed the small_refactor_versioner_middleware branch from c85ece0 to 89b8d0a Compare July 13, 2025 14:48
@ericproulx ericproulx force-pushed the small_refactor_versioner_middleware branch from 89b8d0a to fab7110 Compare July 13, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants