Detect entity representation on attribute values #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I've run into a number of times and (I think) this solves the issue. I'd like feedback in case there are dangers of which I'm not aware here. The problem is this:
With the above code, what I would expect is the JSON representation to look like:
Instead the native JSON representation for the object is coming through. This pull request alters the default behavior when no
:using
or:proc
or block are specified on an exposure and tries to detect an entity for it, first byvalue.entity
then byvalue.class.entity_class.represent(value)
.I believe this is making the behavior more what someone would expect. Any thoughts @dblock or others?