Better clarity on case-when indentation #741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces PR rubocop#422, and maintains a minimum of overall new lines
|
I'm fine with the spirit of the change, I just wonder if this should be a separate rule or not. It's kind of orthogonal to the indentation of |
bbatsov
reviewed
May 3, 2019
README.md
Outdated
| @@ -341,11 +345,26 @@ Translations of the guide are available in the following languages: | |||
| puts 'Too long!' | |||
| when Time.now.hour > 21 | |||
| puts "It's too late" | |||
| when :minus_op, :minus_minus_op | |||
There was a problem hiding this comment.
Given this example, I think we're talking more about Good and Better than about Bad and Good.
There was a problem hiding this comment.
There's just one other precedent in the style guide. I'm happy to make a simple Better block, and try to overall keep the examples 'deduped' to limit newlines.
There was a problem hiding this comment.
Updated @bbatsov. A smaller diff now, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #422, and maintains a minimum of overall new lines.
I just realized that #422 was still open, and re-reading it I think that this edit is more in-line with the intent of the PR, and all the feedback. I hope it will an easy merge.