Fixes for FreeRTOS task creation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FreeRTOS version V11.0.1 or earlier, if configSTACK_DEPTH_TYPE is not defined by user in FreeRTOSConfig.h, the default value set is uint16_t, which is unlikely to be correct. Fixed by replacing configSTACK_DEPTH_TYPE with StackType_t, which should always be correct as it is used internally in xTaskCreate(). See #2351.
Stacks such as i-link assume that os_thread_create() always succeeds. Returning NULL is inconsistent with other create() functions as well as rt-kernel. See #2363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port for FreeRTOS could allocate task stacks twice as large as expected. Furthermore, if out-of-memory when attempting to create a task, the error would go unreported. This would not necessarily lead to a crash, as the returned task handle is often not used.