[rtic-monotonics] Panic if STM32 clock prescaler value overflows #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
force-pushed
the
catch-psc-overflow
branch
from
5b485ae to
0769f09
Compare
AfoHT
reviewed
Jun 24, 2025
rtic-monotonics/CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ For each category, *Added*, *Changed*, *Fixed* add new entries at the top! | |||
|
|
|||
| - Updated esp32c3 dependency to v0.28.0 | |||
| - Updated esp32c3 dependency to v0.27.0 | |||
| - Panic if STM32 prescaler value would overflow | |||
There was a problem hiding this comment.
This changelog entry does not belong to this release.
You should create a new "changed" header under "unreleased" header and place it there instead :)
There was a problem hiding this comment.
ah, I did it too quickly 😅
should be fixed now
antonok-edm
force-pushed
the
catch-psc-overflow
branch
from
0769f09 to
386f72f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had a confusing issue on my STM32 board where I used a TIMx driver for
Monotonicand the timer was progressing ~5.5x faster than it should have been. The system clock was 80MHz and I used 1000 ticks per second for the timer. Turns out there was an overflow in the prescaler configuration. This PR adds an assertion in that case, to make debugging this problem easier for other users in the future.