-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/phpcs fixes #289
base: master
Are you sure you want to change the base?
Fix/phpcs fixes #289
Conversation
Creation of dynamic property RetranscodeMedia::$capability is deprecated in /var/www/htdocs/wp-content/plugins/transcoder/admin/rt-retranscode-admin.php on line 82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 4 errors
Powered by rtCamp's GitHub Actions Library
@@ -1 +1 @@ | |||
<?php //Silence is golden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 Error: You must use "/**" style comments for a file comment (Squiz.Commenting.FileComment.WrongStyle).
@@ -1 +1 @@ | |||
<?php //Silence is golden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 Error: Inline comments must end in full-stops, exclamation marks, or question marks (Squiz.Commenting.InlineComment.InvalidEndChar).
@@ -17,6 +17,13 @@ class RetranscodeMedia { | |||
*/ | |||
public $menu_id; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
@@ -17,6 +17,13 @@ class RetranscodeMedia { | |||
*/ | |||
public $menu_id; | |||
|
|||
/** | |||
* capability of user required to retranscode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 Error: Doc comment short description must start with a capital letter (Generic.Commenting.DocComment.ShortNotCapital).
Creation of dynamic property RetranscodeMedia::$capability is deprecated in /var/www/htdocs/wp-content/plugins/transcoder/admin/rt-retranscode-admin.php on line 82