Merge pull request #34 from rtCamp/fix/issue-33

Fix halt on error

README.md

@@ -53,7 +53,7 @@ This GitHub action's behavior can be customized using following environment vari
 Variable          | Default | Possible  Values                                                    | Purpose
 ------------------|---------|---------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 `MU_PLUGINS_URL`  | null    | vip, any git repo url                                               | If value is `vip`, then action will clone [VIP's MU plugins](https://github.com/Automattic/vip-mu-plugins-public) as `mu-plugins` folder. If you want to specifiy a non-VIP mu-plugins repo, you can provide a publicly accessible mu-plugins repo URL as the value.
-`WP_VERSION`      | latest  | Any valid WordPress version                                         | If you specify a WordPress version, then that speicifc WordPress version will be downloaded, instead of latest WordPress version. WP_VERSION defined in hosts.yml will have higher priority than one defined in workflow file.
+`WP_VERSION`      | latest  | Any valid WordPress version                                         | If you specify a WordPress version, then that speicifc WordPress version will be downloaded, instead of latest WordPress version. **Note:** Please use double quotes while giving value to this variable. Also, `WP_VERSION`, if defined in hosts.yml will have higher priority then the one defined in workflow file.
 `WP_MINOR_UPDATE` | null    | `true` / `false`                                                    | If set to `true`, latest minor version of `WP_VERSION` will be taken.
 `JUMPHOST_SERVER` | null    | Hostname/IP address of the jumphost server                          | If the deployment server is not directly accessible, and needs a jumphost, then this method should be used. (Note: The `SSH_PRIVATE_KEY` env variable should have access to the jumphost as well as deployment server for this to work. Also, this method does not work with vault.)
 `SUBMODULE_DEPLOY_KEY` | null    | Read access deploy key created in the submodule repo's deploy keys. | Only required for privated submodule repo. For now only one private submodule deploy key is allowed. All public submodules in repo will be fetched by default without the need of this env variable. (To create a deploy key go to: Settings > Deploy Keys > Add deploy key)

main.sh

@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
 
+# Exit on error
+set -e
+
 hosts_file="$GITHUB_WORKSPACE/.github/hosts.yml"
 export PATH="$PATH:$COMPOSER_HOME/vendor/bin"
 export PROJECT_ROOT="$(pwd)"
@@ -198,7 +201,7 @@ function setup_wordpress_files() {
 	cd "$HTDOCS"
 	export build_root="$(pwd)"
 
-	hosts_wp_version=$(cat "$hosts_file" | shyaml get-value "$GITHUB_BRANCH.WP_VERSION" 2>/dev/null)
+	hosts_wp_version=$(cat "$hosts_file" | shyaml get-value "$GITHUB_BRANCH.WP_VERSION" || true)
 
 	# Check if WP_VERSION is already defined in hosts.yml
 	# Priority: 1. hosts.yml, 2. workflow file, else use latest