Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployジョブの条件であるpushイベントの対象をmainに変更 #4

Merged
merged 1 commit into from
May 17, 2024

Conversation

KuraZuzu
Copy link
Collaborator

What does this implement/fix?

M5Stack CoreS3に対してWebから書き込む際に失敗する不具合(下記エラー)の修正です。

PR: #3 で行った対象ブランチの修正がdeployジョブに対して漏れが発生していたため追加修正しました。

インストールエラー

Installation failed

Downlading firmware tech.moddable.stackchan/com.m5stack.cores3/bootloader.bin failed: 404

対象issue: #1

Does this close any currently open issues?

不具合対応作業の一部なので、クローズはしません。

How has this been tested?

現時点でテストは実施されていません。
mainに取り込まれた後にWebブラウザから書き込めるかテストする必要があります。

Any other comments?

Checklists

Copy link
Contributor

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです 🙏

@KuraZuzu KuraZuzu merged commit f6c46b1 into main May 17, 2024
4 checks passed
@KuraZuzu KuraZuzu deleted the fix/deployment-bundle-branch branch May 17, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants