Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sciurus17_descriptionをリポジトリから削除し、インストール手順を更新 #135

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

Kuwamai
Copy link
Contributor

@Kuwamai Kuwamai commented Sep 12, 2023

What does this implement/fix?

#134 の作業です。
sciurus17_descriptionをリポジトリから削除し、インストール手順を更新しました。

Does this close any currently open issues?

しません。

How has this been tested?

新しい手順でパッケージをビルドした後、下記コマンドを実行しSciurus17のモデルが表示されることを確認しました。

roslaunch sciurus17_bringup sciurus17_bringup.launch

Any other comments?

ライセンスの変更、バージョンタグの更新については別PRで実施します。

Checklists

@Kuwamai Kuwamai added Type: Breaking Change Includes breaking changes Type: Maintenance Repository Maintenance labels Sep 12, 2023
@Kuwamai Kuwamai self-assigned this Sep 12, 2023
@Kuwamai Kuwamai marked this pull request as ready for review September 14, 2023 01:41
Copy link
Collaborator

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit c8ae98d into master Sep 14, 2023
8 checks passed
@ShotaAk ShotaAk deleted the remove_description_pkg branch September 14, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Includes breaking changes Type: Maintenance Repository Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants