Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option overriding URDF to launch #152

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Apr 12, 2022

What does this implement/fix?

crane_x7_moveit_config/launch/demo.launchにはload_robot_descriptionオプションがあります。

<arg name="load_robot_description" default="true" />

しかし、ここをfalseにした場合でもuse_gazeboがfalseの場合はcrane_x7_control/launch/crane_x7_controlでrobot_descriptionが定義されており、load_robot_descriptionが常にtrueになってしまいます。

crane_x7_moveit_config/launch/demo.launch --> crane_x7_moveit_config/launch/move_group.launch --> crane_x7_control/launch/crane_x7_control の順で呼び出されます。

<param name="robot_description"
command="$(find xacro)/xacro --inorder '$(find crane_x7_description)/urdf/crane_x7.urdf.xacro'"
/>

これを修正します。

ちなみにcrane_x7_moveit_config/launch/demo.launch --> crane_x7_moveit_config/launch/planning_context.launchload_robot_descriptionが渡されるようになっています。

<include file="$(find crane_x7_moveit_config)/launch/planning_context.launch">
<arg name="load_robot_description" value="$(arg load_robot_description)"/>
</include>

<param if="$(arg load_robot_description)" name="$(arg robot_description)" command="$(find xacro)/xacro --inorder '$(find crane_x7_description)/urdf/crane_x7.urdf.xacro'"/>

Does this close any currently open issues?

しません

How has this been tested?

Any other comments?

ハードウェアを改造したCRANE-X7実機を動かす際に必要になるオプションなので使われるケースは少ないと思います。

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh requested a review from ShotaAk April 12, 2022 10:23
@Tiryoh Tiryoh self-assigned this Apr 12, 2022
@Tiryoh Tiryoh added Status: In Progress Work in Progress Status: Need More Info Lacks enough info to make progress labels Apr 12, 2022
@Tiryoh Tiryoh removed the request for review from ShotaAk April 12, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Work in Progress Status: Need More Info Lacks enough info to make progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant