Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGNORMALIZER::CHANGED:: when using '-V' flag, return 0 (zero) when program exits #365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frikilax
Copy link
Contributor

Description

When printing lognormalizer's version through its '-V' flag, the return code is not zero, that return code is counter intuitive and prevents using the command in scripts and/or CI/CD frameworks

Changed

  • return zero when '-V' flag is detected after printing the version number, instead of 1

@rgerhards
Copy link
Member

oops... that sounds indeed bad.

I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)?

@rgerhards rgerhards self-assigned this Oct 13, 2022
@davidelang
Copy link
Contributor

davidelang commented Oct 13, 2022 via email

@rgerhards
Copy link
Member

@davidelang thx!

@rgerhards rgerhards added this to the v2.0.6 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants