Do not byte compile when running tests on multiple versions #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswgnu
approved these changes
Dec 17, 2024
rswgnu
approved these changes
Dec 17, 2024
rswgnu
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Do no byte compile when running multiple tests using docker.
Why
This speeds up running the tests.
Note
This is a quick fix. Making it customizable can be added later if we
feel it is needed.
I noticed when trying this that we get two test that fails. It has something to do with the way how ibuts for paths are created. The test expects an absolute path but we get a relative path instead. Only occurs in docker. Will look into that.