Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cell & HeaderCell generic #474

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

lorefnon
Copy link
Contributor

@lorefnon lorefnon commented Nov 19, 2023

Resolves #472

Copy link

vercel bot commented Nov 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 10:23am

Copy link

codesandbox-ci bot commented Nov 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f36d2ce:

Sandbox Source
React Configuration
JavaScript Configuration

@simonguo
Copy link
Member

Hi @lorefnon , tests failed.
You can execute the test case locally with the following command.

npm run test
// or
npm run tdd

@lorefnon
Copy link
Contributor Author

Hi @simonguo - I have addressed the failures.

Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @b1rdex, children prop should be added to <Table> in readme.

https://github.com/rsuite/rsuite-table/tree/main#table

test/Table.test.tsx Show resolved Hide resolved
Copy link
Member

@simonguo simonguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonguo simonguo merged commit f988cb5 into rsuite:main Nov 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table is generic, but Cell is not
2 participants