Fix type extension #448
Merged
Fix type extension #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
b1rdex
commented
Jul 25, 2023
b1rdex
commented
```
node_modules/rsuite-table/lib/HeaderCell.d.ts:4:18 - error TS2430: Interface 'HeaderCellProps' incorrectly extends interface 'InnerCellProps'.
Types of property 'onResize' are incompatible.
Type '((columnWidth?: number | undefined, dataKey?: string | undefined) => void) | undefined' is not assignable to type 'ReactEventHandler<HTMLElement> | undefined'.
Type '(columnWidth?: number | undefined, dataKey?: string | undefined) => void' is not assignable to type 'ReactEventHandler<HTMLElement>'.
Types of parameters 'columnWidth' and 'event' are incompatible.
Type 'SyntheticEvent<HTMLElement, Event>' is not assignable to type 'number'.
4 export interface HeaderCellProps extends InnerCellProps {
~~~~~~~~~~~~~~~
```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fd8218f:
|
simonguo
reviewed
Jul 28, 2023
| @@ -9,7 +9,7 @@ import ColumnResizeHandler, { FixedType } from './ColumnResizeHandler'; | |||
| import { useUpdateEffect, useClassNames } from './utils'; | |||
| import Cell, { InnerCellProps } from './Cell'; | |||
|
|
|||
| export interface HeaderCellProps extends InnerCellProps { | |||
| export interface HeaderCellProps extends Omit<InnerCellProps, 'onResize'> { | |||
There was a problem hiding this comment.
But there is no definition of onResize in InnerCellProps
There was a problem hiding this comment.
Yes, it's in the React: React.DOMAttributes<T>.onResize?: ReactEventHandler<T> | undefined.
interface StandardProps extends React.HTMLAttributes<HTMLElement> inherits that method
There was a problem hiding this comment.
@simonguo any update?
simonguo
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.