Update dateYMD #4318
Open
Update dateYMD #4318
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid stripping timezone information from POSIX time objects via as.Date
gadenbuie
reviewed
Nov 18, 2025
gadenbuie
reviewed
Nov 18, 2025
gadenbuie
reviewed
Nov 18, 2025
gadenbuie
reviewed
Nov 18, 2025
gadenbuie
reviewed
Nov 18, 2025
Member
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
I fixed the formatting issues, so it's looking good now. Would you like to add a test based on the code in the issue? And we'll need a NEWS bullet, too
Added test for passing POSIX time objects to dateYMD
Contributor
Author
|
Sorry for the late reply - I just added a test and a NEWS bullet. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4317
Avoid stripping timezone information from POSIX time objects via as.Date