Add OpenMind article template#194
Closed
mikabr wants to merge 17 commits intorstudio:masterfrom
mikabr:master
Closed
Add OpenMind article template#194mikabr wants to merge 17 commits intorstudio:masterfrom mikabr:master
mikabr wants to merge 17 commits intorstudio:masterfrom
mikabr:master
Conversation
yihui
reviewed
Mar 14, 2019
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
This PR actually contains three article formats. Is it possible split them into three separate PRs? That will make code review a little easier. If not, I guess I'll have to bit the bullet someday anyway... 😭
Author
|
sorry about that, will fix when I get a chance |
Contributor
|
No worries. Thanks! |
yihui
force-pushed
the
master
branch
3 times, most recently
from
033a19f to
d98786f
Compare
yihui
requested changes
Aug 3, 2020
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Please go through the PR requirements at https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md and try to fix some issues first (e.g. perhaps skeleton.pdf shouldn't be included). Thank you!
Author
|
I redid the PR cleanly with #305 because this one was so messy |
Contributor
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
rticles::opmi_article()template based on the OpenMind LaTeX template.