test: switch reload fixtures to built-in css#187
Merged
chenjiahan merged 2 commits intomainfrom Apr 2, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the hot-reload test setup to rely on Rspack’s built-in CSS handling instead of style-loader/css-loader, and adjusts the fixture HTML + snapshots accordingly.
Changes:
- Switch reload fixtures’
.csshandling from loader-based totype: 'css'. - Update the HTML generator used in tests to include emitted CSS assets via
<link>tags. - Remove loader dependencies and update hot-reload snapshots to match the new HMR output.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/helpers/normalize.js | Removes normalization logic specific to css-loader paths (no longer needed). |
| tests/helpers/html-generator-plugin.js | Injects <link> tags for emitted CSS assets into generated index.html. |
| tests/fixtures/reload-config/rspack.config.js | Switches CSS handling to built-in type: 'css'. |
| tests/fixtures/reload-config-2/rspack.config.js | Switches CSS handling to built-in type: 'css'. |
| tests/e2e/snapshots/hot-and-live-reload.test.js.snap | Updates expected HMR logs after changing CSS pipeline. |
| package.json | Removes css-loader and style-loader deps. |
| pnpm-lock.yaml | Reflects dependency removals and resulting lockfile updates. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
style-loader/css-loaderto built-in CSS handlingTesting
Related Links