Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds consumer-side TypeScript checks to validate @rspack/dev-server public declarations under both bundler and NodeNext module resolution modes, and wires these checks into the repo’s test workflow.
Changes:
- Added two consumer-style type-test projects (
resolution-bundlerandresolution-nodenext) withskipLibCheck: false. - Added a
testsworkspace script to runtscagainst both type-test projects. - Updated root
testflow to run the newtest:typestep beforerstest.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/type-tests/resolution-nodenext/tsconfig.json | New NodeNext-resolution tsconfig with skipLibCheck: false for public type validation. |
| tests/type-tests/resolution-nodenext/index.ts | Imports public entrypoints to force declaration/type resolution under NodeNext. |
| tests/type-tests/resolution-bundler/tsconfig.json | New bundler-resolution tsconfig with skipLibCheck: false for public type validation. |
| tests/type-tests/resolution-bundler/index.ts | Imports public entrypoints to force declaration/type resolution under bundler resolution. |
| tests/package.json | Adds type-check script that runs tsc for both type-test projects. |
| package.json | Adds test:type and wires it into test (runs build + tests workspace type-check). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rspack/dev-serverunder bothbundlerandNodeNextresolutionskipLibCheckin those tests so exported declarations are validated as part of the test flowtest:typeandtestTesting
pnpm run test:typeRelated Links