Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeem promotions #49

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Redeem promotions #49

wants to merge 10 commits into from

Conversation

szandrzej
Copy link
Contributor

No description provided.

@szandrzej szandrzej changed the base branch from master to add_promotions April 25, 2018 13:39
@szandrzej szandrzej changed the title Redeem promotions [DON'T MERGE BEFORE PR #48] Redeem promotions Apr 26, 2018
@szandrzej szandrzej changed the base branch from add_promotions to master April 26, 2018 13:09
tpindel
tpindel reviewed May 7, 2018
View reviewed changes
dist/voucherify.js Outdated
if (!isValidInit(OPTIONS)) {
return null;
}

// if (!code) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szandrzej Why has this code been commented out? Shall we remove these lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpindel tpindel tpindel left review comments

@imvanzen imvanzen Awaiting requested review from imvanzen

@bandraszyk bandraszyk Awaiting requested review from bandraszyk

@darekg11 darekg11 Awaiting requested review from darekg11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szandrzej @tpindel