test CLI without shelling out #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with gets() inside an Async block on Windows. Open an issue at socketry/async#256 |
emiltin
force-pushed
the
cli_test_no_shell
branch
2 times, most recently
from
591a7ac
to
3d09214
Compare
seems to be fixed in async 2.6.3. |
This reverts commit ca3b2d0.
This reverts commit a1481e1.
emiltin
force-pushed
the
cli_test_no_shell
branch
from
a84e51d
to
d28c35b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke our Thor CLI methods directly, instead of actually running in a separate process. This speeds ups tests a lot. We capture stdout and checks what's written line by line, so we can exit tests as soon as expected output is seen.