WIP - Rails 7.2 bind issue #2422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure this should happen. But the on_load hook version is not happening early enough for the Rakefile's clear task.
This reverts commit 049c5d5.
Active record wants '?' as a bind placeholder. Without this it will not
provide bind variables to exec.
Oracle requires :N style bind parameters, so it a translation is
required.
Something went wrong in the translation between rails 7.1 and rails 7.2
so that the where("CONTAINS(table.col, ?, 0) >0", term) was no longer
getting it's bind parameter translated to ':a1' like it should be.
This change drops down to AREL nodes which ensures that the contains
query is getting passed through the visitor pattern, specifically
hitting the visit_Arel_Nodes_BindParam method to convert the param to
':a1'.
I still do not understand what changed in rails, but this workaround is
effective.
|
Please see the cleaner pr at #2424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I've started out trying to update the library to use rails 7.2. I started by moving the rails pin forward to the beginning of the rails 7.2 branch ( rails 8c43b9614eab4d905894d2dd18eda061ef4c4755). I made some progress then have gotten stumped at this error:
I've traced this through and the bound parameters are being provided to the raw cursor.
It seems like the cursor may need some additional setup for the parameter to be bound. Interestingly, other tests that use similar binding of variables seem to work ok. Perhaps it has something to do with binding into a functional argument as is the case here.
I would appreciate any diagnostic suggestions.
Thank you!