remove console.error

rsdc2 · Feb 14, 2024 · c05d4f2 · c05d4f2
1 parent 352a108
commit c05d4f2
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/Errors/mode.js b/src/Errors/mode.js
@@ -0,0 +1,5 @@
+import { ISicElementIDError } from "./isicElementIDError.js";
+
+export class InvalidModeError extends Error {
+
+}
diff --git a/src/Pure/format.js b/src/Pure/format.js
@@ -1,4 +1,6 @@
 import Constants from "./constants/constants.js"
+import { BaseIndexError } from "../Errors/base.js"
+
 
 export default class Format {
 
@@ -21,7 +23,7 @@ export default class Format {
             return "ISic" + padded.slice(0, 6) + "-" + padded.slice(6, 10)    
         }
         else {
-            console.error("Invalid base")
+            throw new BaseIndexError(baseIdx)
         }
 
     }

diff --git a/src/SideEffects/status.js b/src/SideEffects/status.js
@@ -1,9 +1,10 @@
 import Attrs from "./attrs.js"
 import Elems from "./elems.js"
+import { InvalidModeError } from "../Errors/mode.js"
 
 export default class Status {
     /**
-     * @returns {"compression"|"midpoint"|"error"} 
+     * @returns {"compression"|"midpoint"} 
      */
     static selectionMode = () => {
 
@@ -13,7 +14,7 @@ export default class Status {
             return "midpoint"
         }
 
-        console.error("Invalid selection mode")
-        return "error"
+        // This should never happen
+        throw new InvalidModeError(`Invalid selection mode`)
     }
 }