Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Log.Fatal() call Close on the writer before os.Exit(1) #634

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

gmbuell
Copy link
Contributor

@gmbuell gmbuell commented Jan 12, 2024

This fixes the footgun where log.Fatal() does not actually write any messages when used with any kind of buffered writer such as the diode writer.

@rs rs merged commit c1ab4ed into rs:master Jan 13, 2024
1 of 5 checks passed
madkins23 pushed a commit to madkins23/zerolog that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants