Feature: Reading a configuration file. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a very overkill way to do it, but seeing as how I know next to no Golang, it's surprising I got it working at all.
What's even more surprising is that the aficionados report using various stupid hacks to deal with it: globally replacing paths, working on code directly where go get downloaded it, splitting a unit into sub-repositories when other projects are never supposed to import it piecewise, etc, etc. Seeing as how my pull request resulted in no reaction from the original developer, I'm adopting this, and let's make it a learning experience. For starters, let's merge it into one package.
I've noticed that occasionally, commands whose only job is to send a PUB message to another channel do not execute, especially if multiple messages triggering them arrive in quick succession. It appears that due to all the goroutines floating around, it is possible for os.exec.Wait to complete before inputHandler actually gets to do anything to the pipe -- and Wait does not appear to wait for the pipe to be closed on both ends too, so commands can get lost entirely or even fail because the pipe was already closed. Waiting for the inputHandler to complete appears to fix the issue. Concurrency, fun for the whole family.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
After some near-blind mucking around, I managed to do it myself, so here's the PR.
Probably a very overkill way to do it, but seeing as how I know next to no Golang, it's surprising I got it working at all.