Switch from wcharczuk/go-chart to go-analyze/charts #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
commented
Sep 14, 2025
| FillColor: drawing.Color{A: 100}, | ||
| FontColor: chart.ColorWhite, | ||
| FillColor: drawing.Color{A: 100}, | ||
| FontStyle: chart.FontStyle{ |
There was a problem hiding this comment.
Font properties have been now grouped together into a FontStyle struct. This is to make it easier to set the same font properties to multiple style elements.
jentfoo
commented
Sep 14, 2025
| FontSize: 8.0, | ||
| StrokeColor: chart.DefaultAxisColor, | ||
| StrokeWidth: chart.DefaultAxisLineWidth, | ||
| FillColor: chart.ColorWhite, |
There was a problem hiding this comment.
The Default fields are deprecated. I did not anticipate many people referencing these, assuming that instead these were likely used internally. Let me know if you have any opinions on this API change. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have been maintaining a fork of the now-archived wcharczuk/go-chart for over a year.
Since the fork, there have been minimal changes to the original
wcharczuk/go-chartcode, now maintained as thechartdrawpackage. Merging this PR should not change how your charts look or behave, but ensures you depend on an actively supported module.Most development has focused on a new API and chart style in the root
chartspackage (see feature examples). If you want to explore that, I’d be happy to help; if not,chartdrawremains stable and supported.We’re preparing for
v0.6.0and would value any feedback on the rootchartsAPI (chartdrawwill remain stable). Thank you for considering.