Add recording of shadow DOM nodes which have been created with the { mode: 'closed' } flag#1739
Open
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Open
Add recording of shadow DOM nodes which have been created with the { mode: 'closed' } flag#1739eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Conversation
… mode:closed shadow roots, and record them just like open ones
🦋 Changeset detectedLatest commit: 5889179 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
If a reviewer dislikes the addition of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage monkeypatching on
addShadowRootto save a reference to the mode:closed shadow roots, and record them just like open ones