Remove language tag validation, code clean-up #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rrthomas
commented
Sep 24, 2023
•
rrthomas
commented
- Fix some NULL pointer dereferences (thanks, GCC!)
- src/Makefile.am: enchant.1 does not need to be processed by edit script
- enchant-lsmod.c: bump my copyright year
- Add copyright notices to build system and man pages
- Move editor configuration to .editorconfig as far as possible
- lib.c: remove two struct names that are never used
- Update gnulib
- configure.ac: call AC_CHECK_HEADERS with literal values only
- lib.c: allow some whitespace reformatting, since it’s fairly minor
- lib.c: inline the trivial function enchant_free_string_list
- Use GLib logging for debug output
- lib.c: add debug to show what ordering files and dictionaries are found
- .dir-locals.el: 'gnu' is a more accurate style than 'K&R'
- lib.c: simplify post-processing of suggestions
- Fix some licensing nits
- Do not validate language tags
Also add _GL_ATTRIBUTE_MALLOC to some functions.
Put the .editorconfig file in src/ because the style really only applied to files under src, not to the test suite.
The struct definitions are in typedefs, and only the typedef name is used.
Fix an autoconf warning.
Naming it is not really useful, as the name of its callee, g_strfreev, is almost as descriptive.
And document that we do this, so users can get debug output if they want. (Also document ENCHANT_CONFIG_DIR in enchant(5).)
Since there’s only one source now (the back-end provider), assume the suggestions contain no duplicates, and don’t de-dup them. Also, assume there are no empty suggestions (or if there are, that it’s for a good reason). Finally, filter the suggestions against the exclusions list in-place.
Update instructions for getting a copy of the LGPL to use a URL rather than the FSF’s mailing address. Fix some mentions of the GPL which should be of the LGPL.
Dictionaries named with invalid tags (e.g. “fr-toutesvariantes”) are found in the wild. Pass the problem on to consumers; Enchant should permit these tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.